<html>
<head><meta charset="utf-8"><title>FIXME: DefSpans are not really inputs · t-compiler/wg-incr-comp · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/index.html">t-compiler/wg-incr-comp</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html">FIXME: DefSpans are not really inputs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="238536853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/FIXME%3A%20DefSpans%20are%20not%20really%20inputs/near/238536853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html#238536853">(May 12 2021 at 20:12)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> I just saw this (quite old) FIXME mentioning you: <a href="https://github.com/rust-lang/rust/blob/70e52caed91a43fc01867921e67fcd3478056edd/compiler/rustc_middle/src/query/mod.rs#L888-L892">https://github.com/rust-lang/rust/blob/70e52caed91a43fc01867921e67fcd3478056edd/compiler/rustc_middle/src/query/mod.rs#L888-L892</a></p>



<a name="238536863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/FIXME%3A%20DefSpans%20are%20not%20really%20inputs/near/238536863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html#238536863">(May 12 2021 at 20:12)</a>:</h4>
<p>do you know if that still applies?</p>



<a name="238545707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/FIXME%3A%20DefSpans%20are%20not%20really%20inputs/near/238545707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html#238545707">(May 12 2021 at 21:13)</a>:</h4>
<p>IMHO, it does not, since def_span is implemented in terms of hir_owner and hir_owner_nodes.</p>



<a name="238732922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/FIXME%3A%20DefSpans%20are%20not%20really%20inputs/near/238732922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html#238732922">(May 14 2021 at 08:11)</a>:</h4>
<p>I'd need to take a closer look if that FIXME still applies. I vaguely remember that there was something in debuginfo that needed a workaround at some point but that might even predate the red-green system.</p>



<a name="238733822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/FIXME%3A%20DefSpans%20are%20not%20really%20inputs/near/238733822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/FIXME.3A.20DefSpans.20are.20not.20really.20inputs.html#238733822">(May 14 2021 at 08:20)</a>:</h4>
<p>I opened <a href="https://github.com/rust-lang/rust/issues/85281">https://github.com/rust-lang/rust/issues/85281</a> so I don't forget about it.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>